search

SafetyGraphics / safetyCharts

Charts for monitoring clinical trial safety designed for use with {safetyGraphics}
Other
8 stars 7 forks source link

Make meta #97

Closed jwildfire closed 2 years ago

jwildfire commented 2 years ago

In conjunction with https://github.com/SafetyGraphics/safetyGraphics/pull/650

xni7 commented 2 years ago

@jwildfire , nice work! Tested makeMeta in a test repo of qtexplorer and it works fine. A side question is about harmonizing safetyCharts extension pkgs with safetyCharts. How would one consolidate meta data and js dependency libraries? wondering if meta_ecg needs to be ported to qtexplorer?

https://github.com/SafetyGraphics/qtexplorer/blob/master/tests/testthat/test_qtexp.R

jwildfire commented 2 years ago

A side question is about harmonizing safetyCharts extension pkgs with safetyCharts. How would one consolidate meta data and js dependency libraries? wondering if meta_ecg needs to be ported to qtexplorer?

@xni7 I'm not sure the best strategy regarding a meta_ecg migration. The main complication is with the QT versions of the safety widgets that currently live in safetyCharts. Moving those to a different repo should be possible, but might require a few tweaks that we'd have to talk though.

I'd like to finalize this release in the next week or 2, so I'll file an issue, but my preference would be to leave it as is until the next release.

jwildfire commented 2 years ago

I'll file an issue

See #98