SafetyGraphics / safetyGraphics

Clinical Trial Safety Graphics with R
https://safetygraphics.github.io/safetyGraphics/
Other
97 stars 24 forks source link

Add Chart Status Check and integrate in Shiny UI (Fix #562) #670

Closed jwildfire closed 1 year ago

jwildfire commented 2 years ago

Overview

Test Code

See tests/checkChartStatus.R for functional testing. See code below for updates in UI.

a<-makeChartConfig()
a$aeExplorer$dataSpec<-list(
    aes=c("id_col","bodsys_col"),
    dm=c("id_col","treatment_col")
)

a$hepExplorer$dataSpec<-list(
    labs=c("id_col","measure_col")
)

a$aeTimelines$dataSpec <- list(
    aes = c("notacol")
)

safetyGraphicsApp(charts=a)
jwildfire commented 2 years ago

cc: @samussiah @bzkrouse

jwildfire commented 2 years ago

@samussiah Could you do an initial review this PR sometime this week and let me know what you think? Would like to get back to this and make the UI updates next week.

jwildfire commented 2 years ago

Going to try to avoid using shinyjs in tab titles via this approach

jwildfire commented 2 years ago

@bzkrouse @samussiah Ended up doing a fairly significant refactor of the app to simplify the status workflow. Still planning to add a bit more detail and clean up checks etc.

jwildfire commented 2 years ago

Think I'm pretty much done with this. Kept the UI simple for now (added a status icon with some details on mouseover) - can consider making it more complex in a future release (Modal? Separate collapsable Shiny Module?).

jwildfire commented 1 year ago

@samussiah Just bumping this to put it back on your radar.