search

SafranCassiopee / php-metar-decoder

METAR weather observation decoder
GNU General Public License v3.0
50 stars 17 forks source link

Unit converter #12

Closed dkozickis closed 8 years ago

dkozickis commented 8 years ago

Dear All,

Believe propose function will be beneficial for future use. Basically Value class updated with getConvertedValue method (and two supporting methods). This will allow to get value in required units. i.e. METAR has winds speeds in m/s, getConvertedValue('kt') will return winds speeds in KT.

Methods, PHP Docs, covered by tests, tests coverage info -> https://coveralls.io/builds/5015601

Appreciate your review and comments.

Kind regards,

inouire commented 8 years ago

Thank you very much Johnie for this evolution and all the materials around. I'll have a look at it it the next few days and let you know.

inouire commented 8 years ago

@JohnieWalker review done, tell me what you think

dkozickis commented 8 years ago

Hi @inouire ! Thank you for the review. Agree with all points. Variable casing should be same through all project, if brackets was something that I forgot about and did not run code sniffer, Value test moved to separate test.

inouire commented 8 years ago

Thanks for the modification. I just made a few styling remarks on the new ValueTest class, otherwise it's perfect.

dkozickis commented 8 years ago

Hi again @inouire , styling changed according to remarks. Still cant make a habit of running simple Reformat Code in my IDE...

inouire commented 8 years ago

Thank you :+1:

dkozickis commented 8 years ago

Thank you!