search

SafranCassiopee / php-metar-decoder

METAR weather observation decoder
GNU General Public License v3.0
50 stars 17 forks source link

remove 'end of message' and all following characters. #9

Closed r3wald closed 8 years ago

r3wald commented 9 years ago

METAR messages from DWD (German Meteorological Service) often include 'end of message' characters, e.g.

METAR EDDB 041220Z 23014KT 9999 BKN022 08/06 Q1023 TEMPO 24015G25KT=

With this patch these will be ignored.

inouire commented 8 years ago

@r3wald Could we be more precise and focus on = char only at the end of the metar string ? Like this: 

$clean_metar = preg_replace('#=$#', '', trim($raw_metar));
r3wald commented 8 years ago

That's ok with me. Do I have to make a new PR? Don't know Github that well.

inouire commented 8 years ago

No you don't have to make a new PR. You can add a commit to your branch (and push it), it will automatically appear here

r3wald commented 8 years ago

I probably messed it up when pushing. Please have a look at https://github.com/r3wald/php-metar-decoder/tree/remotes/composer/feature-remove-end-of-message.

I see: I pushed to the wrong branch.

inouire commented 8 years ago

Do you want to submit it again ?

r3wald commented 8 years ago

OK, did it.

inouire commented 8 years ago

Perfect, thanks for your contribution !