search

SafwanLjd / EgyBestTeleBot

A Telegram Bot Interface For EgyBest; This Project Has Been Moved to GitLab
https://gitlab.com/SafwanLjd/EgyBestTeleBot
GNU General Public License v3.0
8 stars 3 forks source link

faulty resolution. #4

Closed user45786 closed 1 year ago

user45786 commented 2 years ago

hey i recently noticed that some movies/shows has a faulty resolution like in the picture (240 240 ....) and when downloading from a link .. it's actually not the same as it says... there is miscommunication somewhere.

Screenshot_2022-04-30-23-14-32-925_ir ilmili telegraph

SafwanLjd commented 1 year ago

This is an issue with the original (PyEgyBest)[https://github.com/SafwanLjd/PyEgyBest] library, which is caused by the way it parses the resolution, you have to understand that these resolution values come from the width of the picture of the video file, and with new cinematic media that uses weird aspect ratios, the width of the pictures is rarely a neat round number (i.e. 480, 720, etc), however these are the values that people are used to (mainly because of YouTube), so it just rounds the number of pixels to the nearest neat number, in the case you show, the width just happened to be closer to 240 than to 360 in the case of the first two available resolutions. Anyway I'm closing this issue because, as I said, it has nothing to do with the code in this repo, as it is an issue with the library used.