SagalVanderklok / ChatRoomRecorder

GNU General Public License v3.0
4 stars 0 forks source link

Include FFmpeg with the next release #20

Open Zero3K opened 5 months ago

Zero3K commented 5 months ago

It would be nice if you did that so people don't have to manually download it and configure the program to use it.

zxczxc322 commented 5 months ago

its just qol thing i personally have no problem with manually setting up ffmpeg better add ability to select refreshing speed error status indication(coz its happen sometimes without reason) and then add support other camsites for me in general this tool will be 100 times better than moniturbate

SagalVanderklok commented 5 months ago

It would be nice if you did that so people don't have to manually download it and configure the program to use it.

I need to check that distributing the application with the ffmpeg binary doesn't violate any license agreements

SagalVanderklok commented 5 months ago

its just qol thing i personally have no problem with manually setting up ffmpeg better add ability to select refreshing speed error status indication(coz its happen sometimes without reason) and then add support other camsites for me in general this tool will be 100 times better than moniturbate

Implementing of all these features are planned, but it may require some time. The next release will contain bug fixes and some GUI improvements. After that I'm planning to add detailed info about errors occured and setting for configuring room updates

Zero3K commented 5 months ago

I think that it would be better to download FFmpeg when it is first ran.

SagalVanderklok commented 5 months ago

I think that it would be better to download FFmpeg when it is first ran.

Yeah, I agree, The best option is to include ffmpeg into an MSI package, but if it's not possible due to legal restrictions downloading ffmpeg before the application starts is another option

Zero3K commented 5 months ago

Its license is GPL. It still makes sense to do it separately to keep its archive's size small.

SagalVanderklok commented 5 months ago

While it's distributed under GPL it could include some non-free components (as described here) and it matters how the binary was build

Zero3K commented 5 months ago

Okay.