search

SagarMaheshwary / Employee

A Simple Employee Management System with Materializecss and Laravel
MIT License
104 stars 58 forks source link

NO_AUTO_CREATE_USER #10

Closed arthurkay closed 4 years ago

arthurkay commented 4 years ago

Hi,

I am using PHP 7.3 MySQL V8.0.20

And I am getting the following error.

PDOException::("SQLSTATE[42000]: Syntax error or access violation: 1231 Variable 'sql_mode' can't be set to the value of 'NO_AUTO_CREATE_USER'")

After searching the internet, I found a solution to this issue, which is to deliberately ignore the 'NO_AUTO_CREATE_USER' in Laravel.

More info about this can be found here:

https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sql-mode-full

arthurkay commented 4 years ago

I have a solution to the above, what are the conditions to submit a PR?

SagarMaheshwary commented 4 years ago

There aren't any specific conditions for the pull request. Just commit changes and create a pull request. I will review your pull request before merging those changes.

arthurkay commented 4 years ago

Sorry, I only realised today that you had responded and agreed that I make a PR.