search

Sage-Bionetworks / Agora

MIT License
7 stars 12 forks source link

AG-1344 scaling bug fix and refactor of gene evidence box plots #1281

Closed sagely1 closed 6 months ago

sagely1 commented 6 months ago

These changes look good!

While looking at the examples in the ticket, I noticed that the TMT plot for MDK still isn't shown, even though there is data available. I think this may be related to this code , where selectedUniProtId is determined using the uniprotids from both proteomics_LFQ and proteomics_TMT. For MDK, proteomics_LFQ has E9PPJ5 and P21741 as uniprotids, but proteomics_TMT only has P21741 as uniprotid. E9PPJ5 is set as the selectedUniProtId, but is only found in the LFQ data, so no data is displayed for the TMT plot. Would you mind taking a look? Up to you whether to make the fix here or open a new ticket to track!

Good observation. The nature of the data is that there are times that data for LFQ or TMT may not exist. In that case, we can allow the plots to show as 'no data is currently available'.

hallieswan commented 6 months ago

Good observation. The nature of the data is that there are times that data for LFQ or TMT may not exist. In that case, we can allow the plots to show as 'no data is currently available'.

Oh I see! I didn't notice the dropdown for selecting the uniprotid of interest, which determines which data to show. Thanks for helping me understand!