Sage-Bionetworks / Genie

Validation and processing of GENIE files
https://genie.synapse.org/
MIT License
12 stars 9 forks source link

[GEN-1027] Store failed annotations error report #545

Closed rxu17 closed 8 months ago

rxu17 commented 9 months ago

Purpose: This PR is intended to allow the concatenation and storage to Synapse of the failed annotations per center. This is currently a draft PR - there's some points of discussion needed in some areas.

Changes: Old functions:

New functions: These functions are created primarily for the concatenation and storage to synapse of the annotation reports. We also have a check function that just makes sure our narrow maf failed annotations count match the error report rows.

Testing:

Depends on #544

dpulls[bot] commented 9 months ago

:tada: All dependencies have been resolved !

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

39 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

rxu17 commented 8 months ago

Note that this PR introduces a new variable genomic_location_explanation to the full maf file during mutation processing that leads an issue with the store_maf_files function in genie/database_to_staging.py that will be resolved with #548. See that PR for more details.