Sage-Bionetworks / Genie

Validation and processing of GENIE files
https://genie.synapse.org/
MIT License
12 stars 9 forks source link

[GEN-868] add year death validation #560

Closed danlu1 closed 5 months ago

danlu1 commented 5 months ago

Problem:

Lack of validation check on whether YEAR_DEATH >= YEAR_CONTACT

Solution:

Add the validation check to compare YEAR_DEATH and YEAR_CONTACT when both of them exist and not NAs.

Testing: Unit test has been added.

danlu1 commented 5 months ago

Thanks for doing this! Just some initial comments.

Edit: Could you add more details to the PR description?

Will do

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud