Sage-Bionetworks / challengescoring

This R package provides scoring mechanisms for computational challenges and implements the bayesBootLadderBoot approach for avoiding test data leakage.
Apache License 2.0
3 stars 0 forks source link

check now finishes with some issues #15

Closed andrewelamb closed 4 years ago

andrewelamb commented 4 years ago

Hey @allaway:

I commented out this function call in the vignette:

library(survival)
goldStandard <- Surv(d.time, death) %>% as.character() %>% as.data.frame() %>% magrittr::set_colnames(c("gold"))
predictions <- age_new %>% as.data.frame() %>% magrittr::set_colnames(c("pred"))
prevPredictions <- age_previous %>% as.data.frame() %>% magrittr::set_colnames(c("pred"))

# TODO: fix this error: Error: `by` required, because the data sources have no common variables
# bootLadderBoot(predictions = predictions,
#                predictionColname = "pred", 
#                prevPredictions = prevPredictions,
#                goldStandard = goldStandard,
#                goldStandardColname = "gold",
#                scoreFun = c_statistic,
#                verbose = T)

To get check() to work. The error is not super helpful in this context(this could indicate some error handling could be added to this function).

andrewelamb commented 4 years ago

Oh yes check() is a function that goes through a package and does several things like run the tests, make sure the documentation is correct, runs the vignettes, etc...

allaway commented 4 years ago

IIRC the ability to run this function on Surv objects was never finished. This is related to #11