search

Sage-Bionetworks / data_curator

Data and metadata ingress app
Apache License 2.0
10 stars 21 forks source link

Manifests submitted to same folder when app not refreshed between submissions #228

Closed clarisse-lau closed 2 years ago

clarisse-lau commented 2 years ago

HTAN Vanderbilt contributor submitted an updated biospecimen manifest, followed by 7 clinical (demographics, diagnosis, etc.) manifests on Nov. 4. She re-selected the appropriate folder and template options from the dropdown menus for each submission, without refreshing the app in between. All manifests were stored in the 'biospecimen' folder as new versions.

Initial biospecimen submission: https://www.synapse.org/#!Synapse:syn25010909.10 Subsequent clinical submissions stored as versions 11-17 of the same Synapse file

milen-sage commented 2 years ago

@rrchai could you try replicating?

@clarisse-lau thanks for filing an issue, the expected behavior is there is no refresh needed.

rrchai commented 2 years ago

@clarisse-lau @milen-sage good catch!

The file ID is only updated in the second tab (generating template) in the current code base. So, if the users do not go to the second tab, the folder Id is not updated, which should be a bug.

I have made some changes in pr #230 with other minor improvements related to submission.