Closed rrchai closed 1 year ago
@milen-sage Does the validateModelManifest
now automatically extend {manifest_basename}
with {Component}
, or the manifest should be named as {manifest_basename}_{Component}.csv
in the first place. Also, can you please confirm if {manifest_basename}_{Component}.csv
is the correct format of manifest name?
@afwillia {Component}
can be retrieved using selected$schema()
.
@milen-sage @afwillia Does this ticket have the green light to proceed? I can work on this ticket if it has not been started.
@rrchai yes - I started working on it here https://github.com/Sage-Bionetworks/data_curator/compare/develop...develop-fix-52-dashboard, but there are some extra differences showing up that I want to resolve before creating a PR.
@afwillia Cool! Thanks for looking into it. Feel free to let me know if anything I can help.
This has been incorporated into the REST api branch https://github.com/Sage-Bionetworks/data_curator/tree/beta-schematic-rest-api
Based on the discussion with @milen-sage and @afwillia, the hardcoded
synapse_storage_manifest.csv
is currently used as default manifest name in the app. Theschematic
has updated to use customizable manifest_basename inschematic_config.rds
. Thus, using the hardcoded file name is limited now, since the new uploaded manifests are possible to have names other thansynapse_storage_manifest.csv
.There are two places I notice needed to change:
synapse_storage_manifest.csv
and then upload the file with hardcoded filename to synapse during submissions. It should be stored as{manifest_basename}_{Component}.csv
https://github.com/Sage-Bionetworks/data_curator/blob/e13593c27378f4c02db1d0d448ab57c45c4f53c2/server.R#L415synapse_storage_manifest
andmanifest_basename
to include old and new manifests from fileview table. I suggest to usegrep/grepl
the string patterns instead. https://github.com/Sage-Bionetworks/data_curator/blob/e13593c27378f4c02db1d0d448ab57c45c4f53c2/functions/dashboardFuns.R#L12