Sage-Bionetworks / data_curator

Data and metadata ingress app
Apache License 2.0
10 stars 21 forks source link

TT1 Enable customizable manifest basenames in the app #457

Closed rrchai closed 1 year ago

rrchai commented 1 year ago

Based on the discussion with @milen-sage and @afwillia, the hardcoded synapse_storage_manifest.csv is currently used as default manifest name in the app. The schematic has updated to use customizable manifest_basename in schematic_config.rds. Thus, using the hardcoded file name is limited now, since the new uploaded manifests are possible to have names other than synapse_storage_manifest.csv.

There are two places I notice needed to change:

rrchai commented 1 year ago

@milen-sage Does the validateModelManifest now automatically extend {manifest_basename} with {Component}, or the manifest should be named as {manifest_basename}_{Component}.csv in the first place. Also, can you please confirm if {manifest_basename}_{Component}.csv is the correct format of manifest name?

@afwillia {Component} can be retrieved using selected$schema().

rrchai commented 1 year ago

@milen-sage @afwillia Does this ticket have the green light to proceed? I can work on this ticket if it has not been started.

afwillia commented 1 year ago

@rrchai yes - I started working on it here https://github.com/Sage-Bionetworks/data_curator/compare/develop...develop-fix-52-dashboard, but there are some extra differences showing up that I want to resolve before creating a PR.

rrchai commented 1 year ago

@afwillia Cool! Thanks for looking into it. Feel free to let me know if anything I can help.

afwillia commented 1 year ago

This has been incorporated into the REST api branch https://github.com/Sage-Bionetworks/data_curator/tree/beta-schematic-rest-api