search

Sage-Bionetworks / data_curator

Data and metadata ingress app
Apache License 2.0
10 stars 21 forks source link

Should DCA be able to submit manifests with validation warnings #512

Open afwillia opened 1 year ago

afwillia commented 1 year ago

Is your feature request related to a problem? Please describe. In DCA, you cannot submit a manifest until it has passed validation with schematic. Schematic will return errors and warnings. Should users be able to upload manifests containing warnings?

Screen Shot 2023-03-07 at 11 32 24 AM

GiaJordan commented 1 year ago

@afwillia you should be able to submit with only warnings returned. Right now, for submission after validation, only errors are checked, so this behavior is not intended

rrchai commented 1 year ago

Thanks for bringing up the question!

In DCA, you cannot submit a manifest until it has passed validation with schematic. Schematic will return errors and warnings. Should users be able to upload manifests containing warnings?

There was uncertainty whether users could submit manifests with warnings (such as invalid type, invalid cross-manifest checking) to synapse. So the current behavior was designed to avoid storing any possible invalid manifests (the helper message should've covered the only warnings scenario as well though).

If @milen-sage or @GiaJordan agree that we can upload the manifests with warnings ✅, I think we could then proceed to show the button for manifests only containing warnings.

GiaJordan commented 1 year ago

If @milen-sage or @GiaJordan agree that we can upload the manifests with warnings ✅, I think we could then proceed to show the button for manifests only containing warnings.

Yes, we should proceed. Only errors should prohibit submission @rrchai

afwillia commented 1 year ago

thanks @GiaJordan and @rrchai - I'll add this to our backlog then!