Sage-Bionetworks / dccmonitor

Allows for monitoring of data uploaded via the dccvalidator application. Functions for getting information on the uploaded files, metadata validation status, and more.
https://sage-bionetworks.github.io/dccmonitor
Other
2 stars 4 forks source link

Add OAuth, biospecimen type compatibility, update UI #118

Closed Aryllen closed 2 years ago

Aryllen commented 2 years ago

This is fairly big update. There is a test application here that's currently set to the amp-ad config. Note that there were some test studies that had metadata files uploaded with two different species. I updated them to have the same species. Note that these test files would have failed to validate in the current version of dccmonitor due to this and still will.

Fixed the tests (outside of Mac dev since there appear to be some packages not cached/available for that OS, yet). ~Tests are failing due to an oddity with dccvalidator. 🤔 I'll check into it. The test app is working, though.~

avanlinden commented 2 years ago

I like the new UI with the menu bar rather than the side menu!

When I test-validated some old studies in the test version of the app you linked, I noticed that I was back to getting an error for the grant value in the manifest. Do we need to change the AD annotations table in dccmonitor to be the AD-specific on, e.g. this PR: https://github.com/Sage-Bionetworks/dccvalidator/pull/507#issue-699873470?

Aryllen commented 2 years ago

Yes. Good point, @avanlinden! I'll update that.