Sage-Bionetworks / elevateMS_data_release

Apache License 2.0
2 stars 0 forks source link

Curating Tapping data #1

Open apratap opened 4 years ago

itismeghasyam commented 4 years ago

https://www.synapse.org/#!Synapse:syn21931781/tables/

apratap commented 4 years ago

Please mention any cols that were removed from the original table during the curation.

apratap commented 4 years ago

Also the code for curating tapping data is not on github

itismeghasyam commented 4 years ago

The columns that were removed during the analysis were:

We also removed users who withdrew(syn21927918, #19 ), or were tagged by Vanessa's analysis(syn17870261)

Also the code for curating tapping data (https://github.com/itismeghasyam/elevateMS_data_release/blob/4dfa6b75e7021480d2cab01c6633e6bfcc5a308c/data_curation/curate_data_tapping.R) is linked to the provenance of the table generated. It is in a private repo (were you logged in?)

apratap commented 4 years ago

You are putting the provenance link to your fork. I suggest you use the main repo for the final provenance.

There is no code in the main repo. https://github.com/Sage-Bionetworks/elevateMS_data_release

itismeghasyam commented 4 years ago

Because I haven't yet merged the code into the main repo through a PR, as we haven't yet confirmed which of the curated files are good to go.

Once we decide that the curated tables are good to go, I'll move the files to the main repo and then re-run them

apratap commented 4 years ago

Sounds good

On Wed, Apr 8, 2020 at 11:58 AM Meghasyam notifications@github.com wrote:

Because I haven't yet merged the code into the main repo through a PR, as we haven't yet confirmed which of the curated files are good to go.

Once we decide that the curated tables are good to go, I'll move the files to the main repo and then re-run them

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Sage-Bionetworks/elevateMS_data_release/issues/1#issuecomment-611133302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDVT6RZ7KYF3C6FL3LKELRLTCONANCNFSM4LTZVQQQ .

apratap commented 4 years ago

Ok to freeze