get_heartrate failing for psd and peak methods

Sage-Bionetworks / mhealthtools

A modular R package for extracting features from mobile sensor data

Apache License 2.0

13 stars 10 forks source link

get_heartrate failing for psd and peak methods #179

Open itismeghasyam opened 5 years ago

itismeghasyam commented 5 years ago

The problem is in the if statement in L#226. You just need to run by this loop if the method is 'acf'. Infact just comment this out

philerooski commented 5 years ago

Is this something we can write tests for?

itismeghasyam commented 5 years ago

If we can hard-code some stuff, then yes. But ideally we should be able to at least check the data types of the output for various values of the parameter method. Will include some tests for the datatype check in the next PR 👍

itismeghasyam commented 5 years ago

@larssono Should we still retain the PSD and peak methods in the mhealthtools package or just retain the working acf model?