kinematic_sensor_argument_validator limiting time filter to <50

Sage-Bionetworks / mhealthtools

A modular R package for extracting features from mobile sensor data

Apache License 2.0

13 stars 10 forks source link

kinematic_sensor_argument_validator limiting time filter to <50 #215

Closed JulioV closed 4 years ago

JulioV commented 4 years ago

This line stops time_filter from being bigger than 50. This seems to be a bug as the user could have a time series longer than 50s https://github.com/Sage-Bionetworks/mhealthtools/blob/c4a0af57c594bc9cba11751a0836e6819499b576/R/sensors.R#L360

philerooski commented 4 years ago

Ohh that is definitely a bug. Easy fix, fortunately.

Keep in mind that these IMU feature extraction functions were originally designed to work with sensor data recordings of less than a minute. I've used this package to extract features over 20-minute recordings and it took a loooong time.

philerooski commented 4 years ago

Blocked by #217