search

Sage-Bionetworks / mhealthtools

A modular R package for extracting features from mobile sensor data
Apache License 2.0
13 stars 10 forks source link

EnergyInBand range does not match docs #222

Open JulioV opened 3 years ago

JulioV commented 3 years ago

The function's docs mention that EnergyInBand features are computed for 0.5Hz bins between 0 and 25Hz but the code only does it between 1 and 25Hz

Docs: https://github.com/Sage-Bionetworks/mhealthtools/blob/7c8083bc717fdfe3b1faf1ab28ffc48974f46a40/R/feature_extraction_functions.R#L132

Code: https://github.com/Sage-Bionetworks/mhealthtools/blob/7c8083bc717fdfe3b1faf1ab28ffc48974f46a40/R/feature_extraction_functions.R#L156

philerooski commented 3 years ago

Thanks for filing! Looks like a documentation issue. I wonder what a 0 Hz feature would look like 😆