Sage-Bionetworks / nlp-sandbox

Hub repository for the NLP Sandbox
Apache License 2.0
0 stars 0 forks source link

Implement the data annotator example in Java #15

Closed tschaffter closed 4 years ago

tschaffter commented 4 years ago

So far we have used only python-flask to generate our example NLP Tools. Java is another popular language among programmers and so it would be valuable to check that the openapi-generator can successfully generate a codebase that is compliant with our OpenAPI spec

Task

tschaffter commented 4 years ago

I have generated a server stub that uses Spring Boost. The code has been added to the Date Annotator example repo. I have described how I generated this stub here: https://github.com/Sage-Bionetworks/nlp-sandbox-date-annotator-example#update-the-codebase-when-a-new-openapi-spec-is-available

tschaffter commented 4 years ago

Email sent to Sijia and Connor:

Hi Sijia and Connor,

I have started an implementation of the Date Annotator using Spring Boost (Java). It was easy to generate the server stub using openapi-generator.

https://github.com/Sage-Bionetworks/nlp-sandbox-date-annotator-example#generate-a-spring-boost-server-stub

The next step is to add a small piece of code so that the API does actually detect dates. Ideally I would like this example to behave the same as our Flask-Python example. The business logic is implemented here:

https://github.com/Sage-Bionetworks/nlp-sandbox-date-annotator-example/blob/develop/server/openapi_server/controllers/date_controller.py#L32-L47

Could one of you take care of this task?

Thanks! Thomas

tschaffter commented 4 years ago

We now have the initial implementation: https://github.com/nlpsandbox/date-annotator-example-java

Sijia will add the business logic for detecting date annotations. This task is tracked in this ticket: nlpsandbox/date-annotator-example-java/issues/8