search

Sage-Bionetworks / projectLive_NF

Live view of projects of funding partners
2 stars 3 forks source link

Use projectlive module #102

Closed jaybee84 closed 3 years ago

jaybee84 commented 3 years ago

@andrewelamb : I am starting a pull request for merging in projectLive modules into develop branch

andrewelamb commented 3 years ago

@jaybee84 How do I get this error: "Need a better error response on new submissions page. Currently new submissions page is showing" the new submission page is working as intended for me looking at CTF.

andrewelamb commented 3 years ago

@jaybee84 I see "GFF org info is not rendering properly" is having issues on the study submission page. I'll look into it.

andrewelamb commented 3 years ago

I've made an update that fixes the GFF error. I'm not seeing the other issue however.

andrewelamb commented 3 years ago

@jaybee84 The publication status module is has been moved to the module library. This update also has a few fixes you and @allaway requested.

allaway commented 3 years ago

🎉

On Mon, Feb 22, 2021 at 7:12 AM andrewelamb notifications@github.com wrote:

@jaybee84 https://github.com/jaybee84 The publication status module is has been moved to the module library. This update also has a few fixes you and @allaway https://github.com/allaway requested.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Sage-Bionetworks/projectLive/pull/102#issuecomment-783443398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3WNSGI3NEPSGHYSA2MNZ3TAJX5VANCNFSM4XZMENAA .

jaybee84 commented 3 years ago
Screen Shot 2021-02-22 at 10 40 36 AM

The new submissions page is not functioning properly in this branch

jaybee84 commented 3 years ago

This is a screenshot of publication module from earlier version:

Screen Shot 2021-02-23 at 9 24 56 AM

This is a screenshot of publication module from this branch:

Screen Shot 2021-02-23 at 9 25 37 AM
  1. The "Please hover over plots ...." message is missing. This is also true for snapshot module.
  2. The number of publications in the new version is less than before.
jaybee84 commented 3 years ago

Really like the separation of the config files of the different modules :)

andrewelamb commented 3 years ago

I'm seeing the publication issue, I'll look into it later today