Sage-Bionetworks / projectLive_NF

Live view of projects of funding partners
2 stars 3 forks source link

Update projectlive modules #123

Closed andrewelamb closed 3 years ago

jaybee84 commented 3 years ago

@andrewelamb I am getting the following errors + display anomalies

Screen Shot 2021-04-29 at 9 46 26 AM Screen Shot 2021-04-29 at 9 40 25 AM Screen Shot 2021-04-29 at 9 40 32 AM
jaybee84 commented 3 years ago

Oh nevermind .. the RDS files needed to be remade

andrewelamb commented 3 years ago

Screenshot from 2021-04-30 07-01-10

andrewelamb commented 3 years ago

@jaybee84 I ended up using boxes since I couldn't get valueboxes to be larger than a width of 6. Do you have a preference for ether style in the above screenshot?

jaybee84 commented 3 years ago

I like the top version with the border around the text. It looks neat and tidy.

As I look more, it seems that including the milestone number dropdown and the 1st set of plots inside the box to make it one unit might also look nice. That way we can get rid of the black lines above the box, or between the first set and second set of plots.

So it will effectively be two boxes (researcher reported tracker + internal tracker) inside one big box of Milestone Tracker :)

andrewelamb commented 3 years ago

Here's what that would look like for the top plot:

Screenshot from 2021-04-30 08-43-52

jaybee84 commented 3 years ago

Looks great! Lets do it for both top and bottom plots :)

jaybee84 commented 3 years ago

The newest changes have not updated in the last commit.. @andrewelamb can you please push the last commit one more time?

andrewelamb commented 3 years ago

@jaybee84 are you sure? My last commit is only updating the modules library to the most recent version that has the needed changes.

jaybee84 commented 3 years ago

On my end I am seeing this after pulling in the latest commit

Screen Shot 2021-05-03 at 1 32 35 PM
andrewelamb commented 3 years ago

@jaybee84 can you show me the results of sessionInfo()?

jaybee84 commented 3 years ago

Ah! I think I never restarted my R session after doing a renv::restore(). Got it to work after restarting the session!