Sage-Bionetworks / projectLive_NF

Live view of projects of funding partners
2 stars 3 forks source link

make projectLive OAuth-capable #132

Closed allaway closed 3 years ago

allaway commented 3 years ago

Is your feature request related to a problem? Please describe. The preferred long-term direction for Shiny apps interacting with Synapse is to use OAuth.

.... longer term (again, as @Sujay Patil said) the preferred way to authenticate is via OAuth: The mechanism of passing a token from Synapse via a cookie was developed when we had no other mechanism. It only works when you use your Shiny app’ within Synapse. Authenticating using OAuth will allow your Shiny app’ to run without needing to be embedded in Synapse and has other benefits (including being an industry-standard mechanism). There is an example of how to authenticate a Shiny app’ here (credit goes to @thomas.yu) and the instructions for setting up the requisite OAuth client are here. Any additional questions, please ask!

Describe the solution you'd like OAuth implemented on projectLive, as templated here: https://github.com/Sage-Bionetworks/SynapseShinyApp

Describe alternatives you've considered n/a

Additional context Other important instructions for setting up OAuth: https://docs.synapse.org/articles/using_synapse_as_an_oauth_server.html

thomasyu888 commented 3 years ago

@allaway , @andrewelamb : Its this particular branch: https://github.com/Sage-Bionetworks/SynapseShinyApp/tree/reticulate. I was actually wondering if the oauth component could be created as a golem module? If so, that would be a valuable resource.

andrewelamb commented 3 years ago

@thomasyu888 I had the same thought actually. Since we will shortly have three different projectlive apps, and they will all need this functionality

thomasyu888 commented 3 years ago

yup @andrewelamb! There are lots of apps across Sage that will require this functionality, so creating this module would be highly helpful!