Sage-Bionetworks / rocc-app

Registry of Open Community Challenge (ROCC) web client
Apache License 2.0
0 stars 0 forks source link

Fix long/many topics layout in challenge card #303

Closed rrchai closed 3 years ago

rrchai commented 3 years ago
tschaffter commented 3 years ago

@vpchung - See above. Do you have suggestion on how to handles lots of topics?

I saw somewhere that @rrchai is targetting to have challenge cards that have the same heights, but is it really what we want? This could have been a requirement if we display multiple challenge cards on one line, but currently they appear one on top of another. Therefore it may not really matter if they have different height? Not having the same height contraint could allow us to display all the topics we want.

vpchung commented 3 years ago

@rrchai @tschaffter we can approach it similar to LinkedIn with a "Show more" button, e.g.

Screen Shot 2021-09-27 at 10 43 11 PM Screen Shot 2021-09-27 at 10 44 07 PM

If you're unfamiliar, LinkedIn allows users to choose the top 3 they want to showcase/pin at the top, which I think is a nice way to display and use a limitless amount of tags:

Screen Shot 2021-09-27 at 10 44 51 PM
rrchai commented 3 years ago

Thank you @tschaffter @vpchung. It is helpful brainstorming. If I integrate ideas from all of us, here are three proposals:

Let's assume a challenge can have 50 tag:

Alternatively simpler solutions:

  1. Without the second bullet point above, do not show any tags in the initial rendered card, users can click expand button to see tags.
  2. With some tags displayed initially, instead of using expansion, just add button/text (+(50-N)) on the right of tags container and redirect to the challenge detail page, like @tschaffter suggests.
tschaffter commented 3 years ago

I just had a look at GH and they don't enforce challenge card to have the same height.

image

EDIT: I would adopt a similar approach for now. We can revisit this design when we review the challenge card design together.

rrchai commented 3 years ago

@tschaffter @vpchung As we discussed in the meeting, the card now has flexible heights and displays all the tags.

Screen Shot 2021-10-11 at 9 16 27 AM