Sage-Bionetworks / rocc-schemas

OpenAPI specification of the Registry of Open Community Challenges
Apache License 2.0
0 stars 0 forks source link

Update User schemas #120

Closed tschaffter closed 3 years ago

tschaffter commented 3 years ago

Specification

References

vpchung commented 3 years ago

I previously configured the User schema to use the username for lookup. Based on the Twitter API, should we reconfigure it to use an ID instead? Maybe both?

Currently, the User object is:

With the specs above, the User object will become:

I don't know if an errors property will be needed, as we are handling that within the path, e.g.

  responses:
    '200':
      description: Success
      content:
        application/json:
          schema:
            $ref: ../components/schemas/EmptyObject.yaml
    '400':
      $ref: ../components/responses/NotFound.yaml
    '500':
      $ref: ../components/responses/InternalServerError.yaml
tschaffter commented 3 years ago

@vpchung Looks good to me. I guess Twitter is using User.errors to save recent errors a user experienced. They may use this information to provide user support. For now let's not include this property.

tschaffter commented 3 years ago

@vpchung The new User schemas adds several of the properties listed in this ticket. The only one left out temporarily are verified and organizations.