search

Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
22 stars 12 forks source link

[Task] Remove deprecated OC API client for Angular #1969

Closed tschaffter closed 1 year ago

tschaffter commented 1 year ago

What projects is this feature for?

OpenChallenges

Description

Remove the project openchallenges-api-client

Anything else?

No response

Code of Conduct

tschaffter commented 1 year ago

Deprecated imports used in the app

import { User } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { OrgMembership } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { ChallengeSponsor } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { ChallengeOrganizer } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { DateRange } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { Challenge as deprecatedChallenge } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { Account } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import {
  AuthService as ApiAuthService,
  LocalAuthRequest,
  LocalAuthResponse,
  User,
  UserService,
} from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
tschaffter commented 1 year ago

We should remove first the dependence on the deprecated services, then remove the dependence on deprecated models.

tschaffter commented 1 year ago

After merging #1971, we will have the following remaining dependencies:

import { User } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { OrgMembership } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { ChallengeSponsor } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { ChallengeOrganizer } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { DateRange } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { Challenge as deprecatedChallenge } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
import { Account } from '@sagebionetworks/openchallenges/api-client-angular-deprecated';
rrchai commented 1 year ago

comment out user related services/components that use deprecated API client.