Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
21 stars 12 forks source link

[Design] Difficulty in identifying how soon a challenge starts or closes when using the new filters #2185

Closed tschaffter closed 10 months ago

tschaffter commented 11 months ago

What product(s) is this feature for?

OpenChallenges

Description

Along with new filters like Starting Soon, Closing Soon, etc. we have a new sorter: by Start Date.

However, the challenge cards don't include any date information so it's difficult to identify how soon the challenges start/close or even if the sorting is done in ascending or descending order (we use future dates to past dates).

Anything else?

No response

Code of Conduct

tschaffter commented 11 months ago

Added to Sprint 23.10

vpchung commented 11 months ago

I thought of two options:

  1. Move the status from the footer into the same space as the tagline/headline (left column). One of the benefits of this is that it would allow there to be more space in the footer for the list of incentives.

  2. Keep the status where it is (right column).

In both designs, there would be some allusion to the start/end date, either explicitly (top row) or implicitly (bottom row):

Image

[!NOTE] I have also removed the button border from the status (that Adam previously mentioned as a possible design flaw) and instead utilized a radio button to signify the status.

vpchung commented 11 months ago

@tschaffter @rrchai @gaiaandreoletti @mdsage1

tschaffter commented 10 months ago

I prefer Option 2, see notes below:

vpchung commented 10 months ago

Latest iteration

Screenshot 2023-10-12 at 11 31 57 AM

tschaffter commented 10 months ago

Shall we get rid of the vertical space between the description and the card footer? Below is the production card for reference where the vertical space is not included. Unless it's part of the new design? The font on the new card seems smaller (e.g. description) compared to the production card too. Not sure if the difference comes from a different zoom in/out.

image
vpchung commented 10 months ago

Below is the production card for reference where the vertical space is not included. Unless it's part of the new design?

The screenshots I provided are from our Figma mockups, which have not been updated to reflect the changes made in the app, thus explaining the extraneous space.

I will update the mockups in future iterations.

tschaffter commented 10 months ago

I like the new design. We can discuss the font size and line spacing as part of the implementation review process.

vpchung commented 10 months ago

Just for you, @tschaffter 😬

Image

tschaffter commented 10 months ago

The implementation of the design change will be tracked in https://github.com/Sage-Bionetworks/sage-monorepo/issues/2240