Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
22 stars 12 forks source link

[Story] Upgrade the OC image service to Gradle v8.4 #2335

Closed tschaffter closed 10 months ago

tschaffter commented 10 months ago

What product(s) is this story for?

OpenChallenges

As a user, I want

NA

Description

We are currently running v8. The console shows that there are some features we use that will be deprecated in Gradle ~v9~ v8.4.

EDIT: Gradle v9 is not out yet. Instead, I will upgrade from Gradle v8.3 to v8.4 and optionally address the deprecation warnings related to v9.

Acceptance criteria

No response

Tasks

No response

Anything else?

No response

Have you linked this story to a GitHub Project?

tschaffter commented 10 months ago

Here are the deprecation warnings:

$ ./gradlew build
Starting a Gradle Daemon, 1 incompatible and 1 stopped Daemons could not be reused, use --status for details
Path for java installation '/usr/lib/jvm/openjdk-17' (Common Linux Locations) does not contain a java executable

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 18s
12 actionable tasks: 3 executed, 9 up-to-date
tschaffter commented 10 months ago

Warnings

$ ./gradlew build --warning-mode all

> Configure project :
The Project.getConvention() method has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.4/userguide/upgrading_version_8.html#deprecated_access_to_conventions
The org.gradle.api.plugins.Convention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.4/userguide/upgrading_version_8.html#deprecated_access_to_conventions
The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.4/userguide/upgrading_version_8.html#java_convention_deprecation
Path for java installation '/usr/lib/jvm/openjdk-17' (Common Linux Locations) does not contain a java executable

BUILD SUCCESSFUL in 3s
12 actionable tasks: 12 up-to-date
tschaffter commented 10 months ago

The Project.getConvention() method has been deprecated.

The project is not using this so it's likely a plugin.

tschaffter commented 10 months ago

About Path for Java..., it seems that Gradle will continue to show this message if the environment is fine. See https://github.com/gradle/gradle/issues/22921