search

Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
23 stars 12 forks source link

[Bug] Revisit the Not Found page in OC #2346

Closed tschaffter closed 10 months ago

tschaffter commented 11 months ago

Is there an existing issue for this?

What product(s) are you seeing the problem on?

OpenChallenges

Current behavior

The content of the 404 page is partially masked by the navbar.

image

Expected behavior

The content is not cropped.

Anything else?

No response

Commit ID

No response

Are you developing inside the dev container?

Code of Conduct

vpchung commented 11 months ago

@tschaffter when do you observe this? Is it on the MBP screen? On my end, I only see this if I make the window super short:

Screenshot 2023-11-09 at 12 40 25 PM

Screenshot 2023-11-09 at 12 40 35 PM

tschaffter commented 11 months ago

when do you observe this?

On my MBP 13 inches. It's like the footer is stuck while it should be the case only if there is not enough content in the main container.

tschaffter commented 11 months ago

Maybe by setting a min height to a container that includes page content and configure it so that it does not overlap with the navbar?

vpchung commented 11 months ago

On my MBP 13 inches, my screen looks like this:

Image

Not quite as cut-off as yours, but I can revisit it anyway.

vpchung commented 11 months ago

[set] a min height to a container that includes page content and configure it so that it does not overlap with the navbar?

I believe this is already accounted for in our theme:

html {
  margin-top: constants.$navbar-height;
}
...
.base {
  width: 100%;
  min-height: calc(100vh - constants.$navbar-height - constants.$footer-height);
}

🤔 hmm..

tschaffter commented 11 months ago

The 404 container may overlap with the navbar (see below)

image