search

Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
21 stars 12 forks source link

[Feature] Allow devs to publish docker images from feature branches #2552

Open linglp opened 4 months ago

linglp commented 4 months ago

What product(s) is this feature for?

Schematic

Description

Currently, build-devcontainer-image.yml only gets triggered when there is a push to main. Please update it so that docker images can be published from local branch. For example, in schematic, workflow can be triggered by tags (see workflow here) in certain formats.

This will allow devs to test new features/bug fixes before merging to main. Since schematic API needs to be run in a docker container, this will also allow us to make sure that schematic APIs are working before each deployment.

Anything else?

No response

Code of Conduct

tschaffter commented 4 months ago

Thanks for opening this ticket and sharing workflow used by Schematic.

Is another way to phrase the problem that you want to publish image during the development of a feature, e.g. triggered by pushing a commit to the PR, for the sake of testing the image before merging the feature?

Could these tests be implemented as integration tests that are run by the CI workflow in a way that there wouldn't be a need to publish the image to a registry?