Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
21 stars 12 forks source link

fix(openchallenges): display zero search results #2553

Closed rrchai closed 4 months ago

rrchai commented 4 months ago

Changelog

Preview

Recording 2024-03-08 at 09 28 04


[!NOTE] The changes in this pr will not reintroduce the flickering:

Recording 2024-03-08 at 09 22 58

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'openchallenges-app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'openchallenges-challenge-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'openchallenges-organization-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed for 'openchallenges-image-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

tschaffter commented 4 months ago

@rrchai The flickering is back for me. This happens when reaching the page directly from another website or reloading the page but not when navigating between pages. Can you reproduce this flickering.

Recording 2024-03-08 at 10 13 53

rrchai commented 4 months ago

Interesting, the flickering is not reproduced on my end.

Recording 2024-03-08 at 13 37 30

I wonder if this flickering (from reloading the page) occurred before this PR was implemented on your end?

tschaffter commented 4 months ago

You are right, the flickering is already present on the production site (https://openchallenges.io/challenge). So we never got rid of it...