Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
21 stars 12 forks source link

[Task] Start EDAM concept ID from 1 instead of 0 #2563

Closed tschaffter closed 3 months ago

tschaffter commented 3 months ago

What product(s) is this story for?

OpenChallenges

As a user, I want

No response

Description

This is to align with all the other IDs that are generated with AUTO INCREMENT.

References to existing EDAM IDs need to be updated too in input_data_type.csv and challenges.csv (operation_id property).

Depends on #2557

Acceptance criteria

No response

Tasks

No response

Anything else?

No response

Have you linked this story to a GitHub Project?

tschaffter commented 3 months ago

The head of the CSV data for input data types:

"id","class_id","preferred_label"
"0","http://edamontology.org/data_0005","Resource type"
"1","http://edamontology.org/data_0006","Data"
"2","http://edamontology.org/data_0007","Tool"

Yet the IDs start with 1 in the SQL table:

image

UPDATE: I set the value of all the id in the EDAM CSV file to null ("\N") and the table in the DB still has IDs set, so it looks like the IDs specified in the CSV file are overwritten by SQL AUTO_INCREMENT.

image
tschaffter commented 3 months ago

This ticket will be addressed by #2564

vpchung commented 3 months ago

References to existing EDAM IDs need to be updated too in input_data_type.csv and challenges.csv (operation_id property).

This is already addressed in the OC data sheet.