search

Sage-Bionetworks / sage-monorepo

Where OpenChallenges, Schematic, and other Sage open source apps are built
https://sage-bionetworks.github.io/sage-monorepo/
Apache License 2.0
21 stars 12 forks source link

[Bug] Contributors of the MIDI-B challenge are not visible #2703

Closed tschaffter closed 2 weeks ago

tschaffter commented 3 weeks ago

Is there an existing issue for this?

What product(s) are you seeing the problem on?

OpenChallenges

Current behavior

The contributors of the MIDI-B challenge are not visible on main and in prod. Other challenges successfully show their contributors.

http://localhost:8000/challenge/517/midi-b?tab=contributors

The console shows that the page is trying to make the following request, which fails:

http://localhost:8082/api/v1/organizations/475

Http failure response for http://localhost:8082/api/v1/organizations/475: 404 Not Found

http://localhost:8000/api/v1/organizations/475

{
  "title": "Entity not found",
  "status": 404,
  "detail": "The organization with the ID or login 475 does not exist.",
  "type": "ORGANIZATION-SERVICE-1000"
}

Expected behavior

The contributors should be visible.

Anything else?

This challenge has multiple contributors, but none are displayed. Wondering whether one contributor breaking is preventing all the other contributors for this challenge to be displayed.

Commit ID

40bcf76224dbc6918d2cf8baca596791a455b3cb

Are you developing inside the dev container?

Code of Conduct

tschaffter commented 3 weeks ago

Contribution roles for this challenge (ID 517):

"1215","517","15","challenge_organizer"
"1216","517","171","challenge_organizer"
"1217","517","473","challenge_organizer"
"1218","517","474","challenge_organizer"
"1219","517","475","challenge_organizer"
"1220","517","476","challenge_organizer"
"1221","517","477","challenge_organizer"
"1222","517","131","challenge_organizer"
"1224","517","15","data_contributor"

The org 475 is the only one that is not found.

tschaffter commented 3 weeks ago

@gaiaandreoletti @vpchung The data of the org with ID 475 is breaking the CSV file because of the comma in the name of the org.

"475","Ellumen, Inc.","ellumen,-inc","logo/ellumen.jpg",...
vpchung commented 2 weeks ago

I don't think the problem is the comma in the name of the organization (since we have University of California, San Fransisco + others and those are rendering fine), but the slug is incorrect. Will fix the formatting rules and add a validation check to the data sheet.

EDIT: formatting rule has been updated + validation check has been added for organization.login. Fix should be deployed in the next DB PR update.

tschaffter commented 2 weeks ago

I just triggered the GH workflow.