search

Sage-Bionetworks / sagebio-collaboration-portal

Collaboration Portal developed by Sage Bionetworks
1 stars 0 forks source link

Notes from backlog provenance items #562

Closed ychae closed 4 years ago

ychae commented 4 years ago

This is a single ticket to capture all my notes from the backlog regarding provenance. @jaeddy I can break this down into smaller tickets and/or move them to the prov-service repo, whatever work best for you! I think some of my notes may be duplicates so please feel free to ignore them if they are.

Projects - tooltips aren't working in Activity under projects Insights - works for the creation and attachment the first time but doesn't update if the insight is edited Tools - when a tool is attached to a resource, the provenance is created for the tool under Activity ~but the tooltips don't appear~

Add new activity to project - I think I saw new bubbles be created from the manual activity creation button, ~but I couldn't verify without tooltips~. Also, are all new projects being created with a seed of provenance? Just curious because it looks like brand new projects I create already have activities under the Activity tab.

jaeddy commented 4 years ago

@ychae updating provenance when an Insight is edited is a known issue that I'll be addressing here: Sage-Bionetworks/prov-service#43. The project activities also is something I'll need to update on the prov-service side — there currently isn't a mechanism to specify whether something in provenance is associated with a project, so that page is actually just grabbing the full provenance graph. :)

I'm unable to reproduce the issue with the tooltips. Can you provide a bit more detail?

ychae commented 4 years ago

Umm well... I can't reproduce it any more either so I guess it's not a problem! :: insert magic emoji ::

tschaffter commented 4 years ago

@ychae Is this ticket still relevant?

ychae commented 4 years ago

@tschaffter I'd like to keep this ticket open so that I can remember to test the remaining items from the backlog.

tschaffter commented 4 years ago

@ychae Are there any tasks that must be addressed here? If not, let's close this ticket.

ychae commented 4 years ago

@tschaffter I'll do a local testing of the items I listed above with the latest code and close it if it's no longer necessary.

ychae commented 4 years ago

I pulled fresh code from both the PHCCollaborationPortal and prov-server repos for this testing: