search

Sage-Bionetworks / sagebio-collaboration-portal

Collaboration Portal developed by Sage Bionetworks
1 stars 0 forks source link

EntityService.createAttachments returns of([]) when there are no atta… #564

Closed tschaffter closed 5 years ago

tschaffter commented 5 years ago

…chments (fix #560)

This solves a bug that prevents users to create an Insight when there are no attachments.

tschaffter commented 5 years ago

phccp_attachment_fix

ychae commented 5 years ago

@tschaffter I'm still seeing the same behavior on this branch.

I removed all my docker containers and images and started with a fresh slate. I also ran npm install after pulling down this branch.

insight-without-attachment

tschaffter commented 5 years ago

@ychae I can not reproduce the issue. Can you try again and check that you are running the correct commit? It should show Current Version: 1.0.0-alpha.11-35-g89f9f46@develop-fix-560 in the footer. By the way, it's a good idea to capture the footer when doing screen capture.

ychae commented 5 years ago

Huh, okay, it must have been user error on my part! My bad, it's working now without an entity being attached. Thanks for the fix @tschaffter !

tschaffter commented 5 years ago

Thanks @ychae !