Sage-Bionetworks / synapsePythonClient

Programmatic interface to Synapse services for Python
https://www.synapse.org
Apache License 2.0
67 stars 68 forks source link

[SYNPY-1225] Support authToken only #1041

Closed BryanFauble closed 8 months ago

BryanFauble commented 9 months ago

Problem:

  1. Authentication Token needs to be the only supported mechanism for using the Python Client

Solution:

  1. Removing apiKey, sessionToken, username/password
  2. Removing some dependencies on keyring
  3. Updating doc links
  4. regen the pipefile.lock
  5. Remove password from the encrypted credentials file

Testing:

  1. I did manual testing to verify that I could use my authToken to log in programmatically and via the CLI (synapse login and synapse config)
  2. Update of integration tests and unit tests to remove testing other methods and also using auth token only
pep8speaks commented 9 months ago

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 666:89: E501 line too long (90 > 88 characters) Line 806:89: E501 line too long (91 > 88 characters) Line 1048:89: E501 line too long (89 > 88 characters) Line 1223:89: E501 line too long (89 > 88 characters) Line 1235:89: E501 line too long (89 > 88 characters) Line 1673:89: E501 line too long (91 > 88 characters)

Line 428:89: E501 line too long (93 > 88 characters) Line 433:89: E501 line too long (99 > 88 characters) Line 548:89: E501 line too long (90 > 88 characters) Line 556:89: E501 line too long (90 > 88 characters) Line 2040:89: E501 line too long (90 > 88 characters)

Line 40:89: E501 line too long (89 > 88 characters) Line 48:89: E501 line too long (90 > 88 characters) Line 169:89: E501 line too long (89 > 88 characters) Line 170:89: E501 line too long (90 > 88 characters) Line 178:89: E501 line too long (90 > 88 characters) Line 214:89: E501 line too long (116 > 88 characters) Line 215:89: E501 line too long (138 > 88 characters) Line 216:89: E501 line too long (120 > 88 characters) Line 217:89: E501 line too long (134 > 88 characters)

Line 13:1: F811 redefinition of unused 'Synapse' from line 12 Line 40:32: E711 comparison to None should be 'if cond is None:'

Line 150:89: E501 line too long (96 > 88 characters)

Comment last updated at 2024-01-08 17:37:19 UTC
sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud