search

Sage-Bionetworks / synapsePythonClient

Programmatic interface to Synapse services for Python
https://www.synapse.org
Apache License 2.0
67 stars 68 forks source link

[SYNPY-1416] File model finishing touches for OOP #1060

Closed BryanFauble closed 7 months ago

BryanFauble commented 8 months ago

Problem:

  1. File model was not complete
  2. A file could not be stored in Synapse unless you specified the Parent ID, even if the ID of the file was known

Solution:

  1. Adding in the various flags for get and store that modify how they function
  2. Adding in a copy function
  3. Adding in a change_metadata function
  4. Adding in guard conditions in several areas
  5. Updating the order in which we are concurrently saving Annotations and Activities to reflect the issue noted in https://sagebionetworks.jira.com/browse/PLFM-8251
  6. Updating the File script
  7. Adding in logic to the client.py to allow storing a file if storing with the ID of the file

Testing:

  1. Unit/integration testing
  2. File script provided
pep8speaks commented 8 months ago

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1515:89: E501 line too long (110 > 88 characters) Line 1640:89: E501 line too long (90 > 88 characters)

Line 20:89: E501 line too long (102 > 88 characters) Line 27:89: E501 line too long (89 > 88 characters) Line 65:89: E501 line too long (110 > 88 characters)

Line 60:89: E501 line too long (93 > 88 characters) Line 71:89: E501 line too long (89 > 88 characters) Line 85:89: E501 line too long (89 > 88 characters) Line 128:89: E501 line too long (90 > 88 characters) Line 130:89: E501 line too long (89 > 88 characters) Line 131:89: E501 line too long (89 > 88 characters) Line 145:89: E501 line too long (89 > 88 characters) Line 154:89: E501 line too long (92 > 88 characters) Line 160:89: E501 line too long (89 > 88 characters) Line 163:89: E501 line too long (89 > 88 characters) Line 180:89: E501 line too long (89 > 88 characters) Line 196:89: E501 line too long (89 > 88 characters) Line 237:89: E501 line too long (89 > 88 characters) Line 323:89: E501 line too long (89 > 88 characters) Line 466:89: E501 line too long (89 > 88 characters) Line 468:89: E501 line too long (95 > 88 characters) Line 470:89: E501 line too long (89 > 88 characters) Line 472:89: E501 line too long (101 > 88 characters) Line 474:89: E501 line too long (96 > 88 characters) Line 481:89: E501 line too long (101 > 88 characters) Line 498:89: E501 line too long (90 > 88 characters) Line 569:89: E501 line too long (90 > 88 characters) Line 576:89: E501 line too long (92 > 88 characters) Line 580:89: E501 line too long (116 > 88 characters) Line 631:89: E501 line too long (89 > 88 characters) Line 639:89: E501 line too long (93 > 88 characters) Line 702:89: E501 line too long (110 > 88 characters) Line 731:89: E501 line too long (110 > 88 characters) Line 800:89: E501 line too long (100 > 88 characters) Line 807:89: E501 line too long (90 > 88 characters) Line 809:89: E501 line too long (110 > 88 characters) Line 815:89: E501 line too long (115 > 88 characters) Line 817:89: E501 line too long (89 > 88 characters) Line 821:89: E501 line too long (133 > 88 characters)

Line 24:89: E501 line too long (106 > 88 characters) Line 117:89: E501 line too long (106 > 88 characters)

Line 503:89: E501 line too long (125 > 88 characters) Line 1127:89: E501 line too long (94 > 88 characters) Line 1176:89: E501 line too long (94 > 88 characters)

Comment last updated at 2024-02-06 21:24:10 UTC
sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
94.3% Coverage on New Code
27.3% Duplication on New Code

See analysis details on SonarCloud