[SYNPY-1415] Folder model finishing touches

[BryanFauble]

Problem:

1. The folder model needed some TLC and bug fixing
2. We needed to add some more functionality to the Folder model to make it more usable

Solution:

1. Updating and bug squashing
2. Writing a sync_from_synapse function in the Folder model
3. Including a copy method

Testing:

1. Integration and unit testing
2. Some initial testing (Obviously more is needed) compared to the synapseutils.syncFromSynapse on a project with 10 files/9 directories:

async: 1.9427805209998041 syncFromSynapse: 3.578380188002484

[pep8speaks]

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file synapseclient/models/file.py:

Line 823:89: E501 line too long (128 > 88 characters)

• In the file synapseclient/models/folder.py:

Line 36:89: E501 line too long (89 > 88 characters) Line 353:89: E501 line too long (112 > 88 characters) Line 387:89: E501 line too long (90 > 88 characters)

• In the file synapseclient/models/mixins/storable_container.py:

Line 52:89: E501 line too long (109 > 88 characters) Line 93:89: E501 line too long (90 > 88 characters) Line 97:89: E501 line too long (100 > 88 characters) Line 123:89: E501 line too long (90 > 88 characters) Line 132:89: E501 line too long (109 > 88 characters) Line 169:89: E501 line too long (92 > 88 characters) Line 176:89: E501 line too long (99 > 88 characters) Line 183:89: E501 line too long (96 > 88 characters) Line 193:89: E501 line too long (100 > 88 characters) Line 194:89: E501 line too long (103 > 88 characters) Line 405:89: E501 line too long (93 > 88 characters)

• In the file tests/unit/synapseclient/models/unit_test_folder.py:

Line 337:89: E501 line too long (107 > 88 characters)

Comment last updated at 2024-02-12 16:56:25 UTC

[sonarcloud[bot]]

Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
88.6% Coverage on New Code
10.3% Duplication on New Code

See analysis details on SonarCloud