If an exception was raised during get-download-list we did not print it out anywhere (Exception Swallowing)
Solution:
use .exception on the logger which will capture the exception being raised
Testing:
Verified functionality in a unit test
Also verified by manually placing temporary code in .get() that the exception is logged to console:
Downloading [####################]100.00% 418.0bytes/418.0bytes (227.4kB/s) manifest.csv Done...
[ERROR] Unable to download file
Traceback (most recent call last):
File "/home/bfauble/BryansGreatWorkspace/synapsePythonClient/synapseclient/client.py", line 2195, in get_download_list
entity = self.get(row["ID"], downloadLocation=downloadLocation)
File "/home/bfauble/.pyenv/versions/3.8.18/lib/python3.8/contextlib.py", line 75, in inner
return func(*args, **kwds)
File "/home/bfauble/BryansGreatWorkspace/synapsePythonClient/synapseclient/client.py", line 1098, in get
raise SynapseError("This is a test error")
synapseclient.core.exceptions.SynapseError: This is a test error
[WARNING] A manifest was created, but no files were downloaded
Manifest file: manifest_1708712431265684147.csv
Problem:
Solution:
.exception
on the logger which will capture the exception being raisedTesting:
.get()
that the exception is logged to console: