Sage-Bionetworks / synapsePythonClient

Programmatic interface to Synapse services for Python
https://www.synapse.org
Apache License 2.0
65 stars 67 forks source link

[SYNPY-1420] Clean up otel spans #1079

Closed BryanFauble closed 3 months ago

BryanFauble commented 3 months ago

Problem:

  1. OTEL span were a bit all over the place with varying depth and information

Solution:

  1. Focus OTEL spans on the I/O portions of the application to know when requests are start/stopping or long running MD5 calculations are taking place

Testing:

  1. Verified by running the upload benchmark script and checking a Jaeger container deployed on my local: image
pep8speaks commented 3 months ago

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 546:89: E501 line too long (89 > 88 characters)

Comment last updated at 2024-04-02 21:37:56 UTC
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud