search

Sage-Bionetworks / synapsePythonClient

Programmatic interface to Synapse services for Python
https://www.synapse.org
Apache License 2.0
65 stars 67 forks source link

[SYNPY-1466] update user agent for command line #1090

Closed danlu1 closed 2 months ago

danlu1 commented 2 months ago

Problem:

In the datawarehouse, the client version isn’t being parsed for user_agent of the synapse command line client

Solution:

Update the user agent of the synapse command line client by removing the synapseclient substring with empty string so the client version can be pulld by Synapse-ETL-Jobs

Testing:

Passed both unit test and integration test

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

danlu1 commented 2 months ago

Thanks. @BryanFauble Do I wait for the Flaky Integration tests ticket solved to merge the PR or merge it now and rebuild the CICD later? I just tested this on my local and haven't checked the snowflake database. But I'm on it. So tomorrow we might be able to know.

BryanFauble commented 2 months ago

Thanks. @BryanFauble Do I wait for the Flaky Integration tests ticket solved to merge the PR or merge it now and rebuild the CICD later? I just tested this on my local and haven't checked the snowflake database. But I'm on it. So tomorrow we might be able to know.

We can wait for Flaky Integration tests to be merged in. I am waiting on the pipelines to build before I update https://github.com/Sage-Bionetworks/synapsePythonClient/pull/1085 to non-draft status.

BryanFauble commented 2 months ago

@danlu1 https://github.com/Sage-Bionetworks/synapsePythonClient/pull/1085 is ready to be reviewed. When that is approved and merged please pull develop back into your feature branch and we should see a successful CI build afterword.