Sage-Bionetworks / synapsePythonClient

Programmatic interface to Synapse services for Python
https://www.synapse.org
Apache License 2.0
65 stars 67 forks source link

[SYNPY-1356] Updating logic around activity/annotations to be optional #1099

Closed BryanFauble closed 1 month ago

BryanFauble commented 1 month ago

Problem:

  1. Some changes I introduced in https://github.com/Sage-Bionetworks/synapsePythonClient/pull/1098 would change default behavior in ways we did not want that would cause some potential data deletion.

Solution:

  1. Updating changed logic to be behind optional booleans that allow folks to have more fine tuned control over how changes can be synced to synapse.

Testing:

  1. Relying on the integration test cases
pep8speaks commented 1 month ago

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 444:89: E501 line too long (105 > 88 characters) Line 764:89: E501 line too long (91 > 88 characters)

Comment last updated at 2024-05-20 16:45:59 UTC