Sage-Bionetworks / synapsePythonClient

Programmatic interface to Synapse services for Python
https://www.synapse.org
Apache License 2.0
65 stars 67 forks source link

[SYNPY-1341 & SYNPY-1479] Change syntax for conditional of ghcr release job #1102

Closed jaymedina closed 1 month ago

jaymedina commented 1 month ago

problems

problem 1) The latest v4.3.0 release did not trigger the CI job written to push the latest synapsepythonclient package to the GHCR. problem 2) It would be nice to have a pre-release image before an official release that validators can use to verify functionality is working as expected

solution

testing & preview

RE: problem 1)

image image

RE: problem 2)

pre-release: https://github.com/Sage-Bionetworks/synapsePythonClient/releases/tag/v0.0.0-rc

package: https://github.com/Sage-Bionetworks/synapsePythonClient/pkgs/container/synapsepythonclient/224686708?tag=v0.0.0-rc-prerelease

image
BryanFauble commented 1 month ago

Fyi I also made https://sagebionetworks.jira.com/browse/SYNPY-1479 that we could tackle now or later. Just something else I was thinking about that we could publish an image for. That way we have the maximum number of ways for folks to verify the changes.

jaymedina commented 1 month ago

Hey @BryanFauble a pre-release image for easier validating is a good idea. I'm happy to take this on, and what I'll do then, is rescope this PR to include the work for 1479, where I use this syntax on the "pre-release" job and the "official release" job.