Sage-Bionetworks / synapsePythonClient

Programmatic interface to Synapse services for Python
https://www.synapse.org
Apache License 2.0
65 stars 67 forks source link

[SYNPY-1476] Increase code coverage and stage files #1106

Closed BryanFauble closed 3 weeks ago

BryanFauble commented 1 month ago

Problem:

  1. Code coverage around download functions in terms of integration tests is severely lacking.
  2. Some dependency imports need to be updated to start pointing at locations where new code is going to exist.

Solution:

  1. Adding integration tests to cover more scenarios.
  2. Staging files to be ready for future changes. In particular, the download_async.py file is close to a copy of download_threads.py as it is going to replace that python script.

Testing:

  1. Integration testing
pep8speaks commented 1 month ago

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 102:89: E501 line too long (112 > 88 characters) Line 234:89: E501 line too long (98 > 88 characters) Line 291:89: E501 line too long (90 > 88 characters) Line 304:89: E501 line too long (89 > 88 characters) Line 305:89: E501 line too long (92 > 88 characters) Line 340:89: E501 line too long (90 > 88 characters) Line 392:89: E501 line too long (95 > 88 characters) Line 419:89: E501 line too long (96 > 88 characters) Line 420:89: E501 line too long (105 > 88 characters) Line 433:89: E501 line too long (94 > 88 characters)

Line 561:89: E501 line too long (147 > 88 characters)

Line 253:89: E501 line too long (90 > 88 characters) Line 256:89: E501 line too long (137 > 88 characters)

Line 160:89: E501 line too long (106 > 88 characters) Line 421:89: E501 line too long (92 > 88 characters) Line 425:89: E501 line too long (90 > 88 characters)

Comment last updated at 2024-06-12 16:12:33 UTC