Sage-Bionetworks / synapser

An R package providing programmatic access to Synapse
Apache License 2.0
32 stars 21 forks source link

SYNR-1474 expose underscore functions #295

Closed jkiang13 closed 3 years ago

jkiang13 commented 3 years ago

Any Synapse python functions with underscores in them would generate generic methods in synapser that would not be exported because of the configured NAMESPACE rule. For example the Python Synapse#create_snapshot_version function would be converted to synCreate_snapshot_version which would not be exported because it still had underscores in its name.

In the companion PythonEmbedInR change https://github.com/Sage-Bionetworks/PythonEmbedInR/pull/102 all names are fully converted to camel case. This change then ensures that the newly exposed functions have the expected man documentation. It also avoids for now a conflict between two versions of annotation functions in the Python client (e.g. setAnnotations and set_annotations which would convert to the same camel case of synSetAnnotations. For now the old behavior is preserved to ensure backwards compatibility, and the new signatures are not included in synapser (they weren't before either because of the underscore issue).