Sage-Future / fatebook

The fastest way to make and track predictions
https://fatebook.io
MIT License
28 stars 8 forks source link

Adds BinaryQuestion component #24

Closed jonnyspicer closed 2 months ago

jonnyspicer commented 2 months ago

Pull Request: Adds BinaryQuestion component

Notes

I'd still like to refactor the BinaryQuestion component more, and will likely do this as part of creating the MCQ component by pulling out any code fragments that can be shared between the two. The next step will be to create a QuestionTypeSelection component and a MultipleChoiceQuestion component. With the URL constant, over time it'd be good to try to move all hardcoded values to constants (particularly strings). Rather than spending a lot of time refactoring now, I'll aim to make these changes whenever I'm touching that part of the codebase anyway.

Changes Made

Testing

Tested locally and on preview deployment, I seem to be able to create and resolve questions fine on both.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forecast-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 2:41pm
adam-binks commented 2 months ago

Lgtm!