search

Sage-Future / fatebook

The fastest way to make and track predictions
https://fatebook.io
MIT License
28 stars 8 forks source link

Fixes question suggestions issue #26

Closed jonnyspicer closed 2 months ago

jonnyspicer commented 2 months ago

Pull Request: Fixes question suggestions issue

Changes Made

Testing

Tested on localhost

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forecast-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 11:58am
jonnyspicer commented 2 months ago

Do you know what introduced the issue - was it me updating all our packages including React, which changed how forward refs work somehow, or something? If that's the case, I guess other ref forwarding stuff might be broken elsewhere, probably worth checking.

I'm not entirely sure to be honest - I looked through my commits that have already made it to main, and while I did touch Predict.tsx, it's not obvious to me why any of the changes would affect the Question Suggestions. I would be pretty surprised if updating any packages caused the change too though, I would assume maintainers would try and avoid this kind of backwards incompatible change. I am ~75% sure it must've been one of my changes and I'm just missing why exactly it broke things.