search

Sage-Future / fatebook

The fastest way to make and track predictions
https://fatebook.io
MIT License
28 stars 8 forks source link

Add 'Unresolved' filter #31

Closed ForrestWeiswolf closed 1 month ago

ForrestWeiswolf commented 1 month ago

Add a filter to show only unresolved questions. Closes #19

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forecast-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 5:17pm
adam-binks commented 1 month ago

Hmm, playing with this locally, I think this is too many filter buttons shown by default - looks too crowded to me. I think we should hide it inside the filter button toggle instead, what do you think?

image

Previously, you got this nice search bar placement:

image

but now it overlaps the Your forecasts title:

image

(Nitpicking because this is one of the first things you see on the site, so want to have especially high standards for it!)

ForrestWeiswolf commented 1 month ago

I've changed it to be hidden by default Also, refactored the whole component

adam-binks commented 1 month ago

Looks good to me, thank you!

adam-binks commented 1 month ago

Proposed general norm: I'll leave it for you to press "Rebase and merge" and check that the deployment works and the changes work in prod

ForrestWeiswolf commented 1 month ago

Proposed general norm: I'll leave it for you to press "Rebase and merge" and check that the deployment works and the changes work in prod

Seems reasonable. I think since this'll be the first time I do it I'll wait until during normal work hours for you, just on the off-chance something weird happens and I wind up with urgent questions