Sage / carbon

Carbon by Sage | ReactJS UI Component Library
https://carbon.sage.com
Apache License 2.0
277 stars 86 forks source link

`disableClose` prop has no effect on `DialogFullscreen` #6182

Open clheppell opened 1 year ago

clheppell commented 1 year ago

Current behaviour

The disableClose prop listed in the storybook docs and typescript types has no impact on a DialogFullscreen and that you can still click on the X or Escape to close the dialog. I'm told by our QAs that it works on a normal Dialog.

Expected behaviour

Either the prop to work or not be documented.

CodeSandbox or Storybook URL

https://codesandbox.io/s/dazzling-wilson-y625xz?file=/src/App.js

JIRA Ticket (Sage Only)

No response

Suggested Solution

No response

Carbon Version

118.2.1

Design Tokens Version

No response

What browsers are you seeing the problem on?

Firefox, Chrome

What Operating System are you seeing the problem on?

Windows

Anything else we should know?

No response

Confidentiality

robinzigmond commented 1 year ago

FE-6053