Sage / carbon

Carbon by Sage | ReactJS UI Component Library
https://carbon.sage.com
Apache License 2.0
278 stars 85 forks source link

Pager header not displayed correctly with Pod #6308

Closed hagad closed 1 year ago

hagad commented 1 year ago

Current behaviour

The is an issue with Pager if we want to display it with the Pod component. See the expected design

Expected behaviour

The expected design :

Capture d’écran 2023-09-08 à 14 19 33

CodeSandbox or Storybook URL

https://codesandbox.io/s/nostalgic-star-5vlw5m?file=/src/App.js

JIRA Ticket (Sage Only)

No response

Suggested Solution

No response

Carbon Version

119.10.0

Design Tokens Version

No response

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS

Anything else we should know?

No response

Confidentiality

tomdavies73 commented 1 year ago

Hi @hagad as far as we can tell the code sandbox looks correct compared to the design you've provided. Is there a specific issue you would be able to tell us about?

hagad commented 1 year ago

Hi @tomdavies73 the issue is that the pager is not closed as expected. It should like the expected design I provided.

Parsium commented 1 year ago

It appears the top border on Pager is currently missing, likely because we are accounting for when Pager is used with FlatTable, where we don't want a top border with rounded corners:

Screenshot 2023-09-19 at 11 26 17

Parsium commented 1 year ago

Looking at the Design System documentation on their Pagination component, there doesn't seem to be any guidance around using the component separately to a table. I will raise this as an issue with them before we make this change.

carbonci commented 1 year ago

:tada: This issue has been resolved in version 121.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: